Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import dialog when fetch #3025

Merged
merged 7 commits into from
Aug 1, 2017
Merged

Conversation

mpele
Copy link
Contributor

@mpele mpele commented Jul 18, 2017

During fetching of new entry it is examined the existence of duplicates. If there is a duplicate, the ImportInspectionDialog is started. By this change user will be informed about possible duplicates and he will be able to decide what to do with it.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@mpele mpele closed this Jul 18, 2017
@mpele mpele reopened this Jul 19, 2017
@lenhard lenhard added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 24, 2017
Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request! I've just tested this locally and it seems to work as expected.

To get this merged, please fix the formatting errors that are indicated by checkstyle so that the travis build passes. Moreover, please add a changelog entry that describes your changes.

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Siedlerchr
Copy link
Member

Thank you very much for your contribution! 👍
Feel free to take care of any other issues!

@Siedlerchr Siedlerchr merged commit d938a3e into JabRef:master Aug 1, 2017
@mpele mpele deleted the importDialogWhenFetch branch August 1, 2017 19:28
Siedlerchr added a commit that referenced this pull request Aug 6, 2017
* upstream/master:
  Add warning message if group with same name is already present (#3077)
  Fix #3062: Ctrl + F works again
  Fix del/copy/paste key trigger main table action in search bar (#3070)
  Fix markdown
  Update gradle from 4.0.1 to 4.0.2
  Fix #3045 Update Transformer plugin
  Reimplement MappedList using a backigList (#3069)
  Fix importing preferences after resetting without restarting (#3065)
  Fix some spotbugs issues (#3060)
  Import dialog when fetch (#3025)
  Adapt CircleCI build
  Adapt CI script
  Closes #3027 and updates install4j to v7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants